Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flamenco: partitioned epoch rewards/rewards re-work #2253

Merged
merged 1 commit into from
Aug 13, 2024
Merged

flamenco: partitioned epoch rewards/rewards re-work #2253

merged 1 commit into from
Aug 13, 2024

Conversation

topointon-jump
Copy link
Contributor

@topointon-jump topointon-jump commented Jun 28, 2024 •
edited
Loading

Reworked rewards code:

  • Re-write to be structured more similarly to Agave, for ease of auditing.
  • Re-work reward data structures to avoid extraneous copying and reduce memory usage.
  • Remove all usages of libc malloc/realloc.
  • Add support for partitioned epoch rewards, without duplicating reward logic.

@topointon-jump topointon-jump force-pushed the topointon/partitioned-epoch-rewards branch 2 times, most recently from 0d3d6ca to ecd4abd Compare July 12, 2024 14:17
@topointon-jump topointon-jump force-pushed the topointon/partitioned-epoch-rewards branch 4 times, most recently from ae7010d to 76eaf37 Compare July 24, 2024 16:38
@topointon-jump topointon-jump force-pushed the topointon/partitioned-epoch-rewards branch 3 times, most recently from 1e00317 to 272166b Compare August 5, 2024 22:02
@topointon-jump topointon-jump changed the title [WIP] flamenco: partitioned epoch rewards flamenco: partitioned epoch rewards/rewards re-work Aug 5, 2024
@topointon-jump topointon-jump marked this pull request as ready for review August 5, 2024 22:04
@topointon-jump topointon-jump force-pushed the topointon/partitioned-epoch-rewards branch from cb61c5d to 2bacd17 Compare August 7, 2024 13:20
jumpsiegel
jumpsiegel previously approved these changes Aug 12, 2024
View reviewed changes
jumpsiegel
jumpsiegel previously approved these changes Aug 12, 2024
View reviewed changes
@topointon-jump topointon-jump force-pushed the topointon/partitioned-epoch-rewards branch from 5a6202c to 82b208e Compare August 12, 2024 19:36
@jumpsiegel jumpsiegel self-requested a review August 12, 2024 19:50
@topointon-jump topointon-jump force-pushed the topointon/partitioned-epoch-rewards branch 3 times, most recently from cc756c3 to 718f407 Compare August 12, 2024 20:55
lheeger-jump
lheeger-jump requested changes Aug 12, 2024
View reviewed changes
src/flamenco/runtime/fd_runtime.c Outdated Show resolved Hide resolved
@topointon-jump topointon-jump force-pushed the topointon/partitioned-epoch-rewards branch from 5fb63b2 to c566ff7 Compare August 13, 2024 14:41
jumpsiegel
jumpsiegel previously approved these changes Aug 13, 2024
View reviewed changes
@ibhatt-jumptrading
Copy link
Contributor

Can we add ledger tests

@topointon-jump topointon-jump force-pushed the topointon/partitioned-epoch-rewards branch from c566ff7 to d189fca Compare August 13, 2024 15:09
@topointon-jump topointon-jump force-pushed the topointon/partitioned-epoch-rewards branch from 16de4a0 to 1b4ff18 Compare August 13, 2024 15:50
@topointon-jump topointon-jump added this pull request to the merge queue Aug 13, 2024
Merged via the queue into main with commit 620461b Aug 13, 2024
11 checks passed
@topointon-jump topointon-jump deleted the topointon/partitioned-epoch-rewards branch August 13, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lheeger-jump lheeger-jump lheeger-jump approved these changes

@jumpsiegel jumpsiegel jumpsiegel left review comments

@ibhatt-jumptrading ibhatt-jumptrading Awaiting requested review from ibhatt-jumptrading

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@topointon-jump @ibhatt-jumptrading @jumpsiegel @lheeger-jump