Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphinx docs fix #44 #45

Merged
merged 1 commit into from
Jun 17, 2023
Merged

Sphinx docs fix #44 #45

merged 1 commit into from
Jun 17, 2023

Conversation

KukovecRok
Copy link
Contributor

@KukovecRok KukovecRok commented Jun 17, 2023

Due to local windows problems, cannot install pyqt5 with poetry.
Sphinx docs should be fixed now #44 . Please rebuild .pdf / .html locally with PyQt5 installed to test it @firefly-cpp

@KukovecRok KukovecRok changed the title Sphinx docs fix Sphinx docs fix #44 Jun 17, 2023
@firefly-cpp
Copy link
Owner

Thanks @KukovecRok!

Good catch. It is probably time that we switch to pyqt6. It should be straightforward. What do you think?

@firefly-cpp firefly-cpp merged commit dfb8af6 into firefly-cpp:main Jun 17, 2023
@firefly-cpp
Copy link
Owner

@all-contributors please add @KukovecRok for docs, bug

@allcontributors
Copy link
Contributor

@firefly-cpp

I've put up a pull request to add @KukovecRok! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants