Directory restructure #1184
Directory restructure #1184
Conversation
|
Awesome! This will land before the toolbox console work. My guess is the timeout I'd related to the node try script moving network requests Thanks for doing this! |
|
Gah, I really don't get the failure. It's not present in master currently but is in this branch. @jasonLaster if you could give it a try and see if you have any ideas it'd be great (I'll be on IRC tomorrow or should be, I just need to configure my client heh) |
|
@wldcordeiro just pushed a fix. It was tough to track down! |
@Garbee helped us expand the scope of our js lints recently. One of the consequences was that there were some matched files that were ignored, which showed up in eslint warnings. This addressees that by: 1. moving tree.js to the sham modules package 2. burning imstruct 3. narrowing the scope of the glob to just the toolbox, the other packages don't matter. * devtools-modules we don't want to change, * devtools-sham-modules are copy paste and tweaks from devtools-modules. so we don't want to match * devtools-config is tiny and will likely go away with the toolbox work * network-config is even smaller and could likely go away soon too...
… debugger rendering
jasonLaster
force-pushed
the
directory-restructure
branch
from
51f235c to
4cc4dcd
Compare
|
@wldcordeiro just rebased. this should hopefully be good to go soon |
|
Looks good now. Tried it out locally and tests pass as well as CI |
jasonLaster
force-pushed
the
directory-restructure
branch
from
4cc4dcd to
9884c63
Compare
There was a problem hiding this comment.
👍
This is amazing work @wldcordeiro. You've changed the shape of the project. This is not easy at this scale with this many moving pieces!
Associated Issue: #1153
Summary of Changes
src/convention rather than apublic/jsconvention.Testing
npm testnpm run lintScreenshots/Videos (OPTIONAL)
@jasonLaster @jlongster want to give this a good review? Might have missed something. One test also fails for me with a timeout. Not sure what I can do about that.