This repository has been archived by the owner on Sep 21, 2021. It is now read-only.
WIP: Upgrade to webpack 3 #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonLaster
force-pushed
the
bump-package-version
branch
from
c686079
to
6bb6b69
Compare
jasonLaster
force-pushed
the
bump-package-version
branch
from
6bb6b69
to
10fb4db
Compare
TheLarkInn
reviewed
Aug 1, 2017
There was a problem hiding this comment.
It would be extra work, but IMO might pay off later down the road to alter the structure of this config while you can for different development environments by breaking it out to be a bit more composable. Here's an example https://github.com/TheLarkInn/webpack-academy-starting-out-right/blob/master/webpack.config.js
jasonLaster
force-pushed
the
bump-package-version
branch
from
10fb4db
to
52dd2c7
Compare
jasonLaster
approved these changes
Aug 1, 2017
|
@TheLarkInn I do absolutely agree with that. I think current configs are a bit complicated and would love it to be more functional in nature. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I upgraded webpack to version 3 for launchpad. Also I bumped flow to version 0.50, updated lerna to a stable version, made sure lerna uses yarn client now.
This requires extensive testing, as while it is running when I do
yarn start, there might be several regressions. But I suppose that full testing might be done only after we bump launchpad version and check it in debugger.html?There might be issues with Chrome, as one portion of the webpack config which was used as a hack to fix Chrome performance is not working anymore.