Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in 2.9.0 #2276

Closed
jagerman opened this issue Mar 6, 2019 · 2 comments
Closed

Bug in 2.9.0 #2276

jagerman opened this issue Mar 6, 2019 · 2 comments
Assignees
@psychocrypt
Labels
backend cpu bug

Comments

@jagerman
Copy link
Contributor

jagerman commented Mar 6, 2019 •
edited
Loading

The != on this line is definitely wrong (should probably be ==?):

xmr-stak/xmrstak/backend/cpu/crypto/cryptonight_aesni.h

Line 801 in 61e997c

if(ALGO == cryptonight_monero_v8 || ALGO == cryptonight_r || ALGO != cryptonight_r_wow) \

@psychocrypt psychocrypt self-assigned this Mar 6, 2019
@psychocrypt
Copy link
Collaborator

Well spotted! I will fix it today!

psychocrypt added a commit to psychocrypt/xmr-stak that referenced this issue Mar 6, 2019
@psychocrypt
fix wrong logic operator usage
746cf7f 
fix fireice-uk#2276
@psychocrypt psychocrypt mentioned this issue Mar 6, 2019
Merged
@psychocrypt
Copy link
Collaborator

fixed with #2280

gnagel pushed a commit to gnagel/xmr-stak that referenced this issue Mar 23, 2019
@psychocrypt
fix wrong logic operator usage
e3eb9e1 
fix fireice-uk#2276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psychocrypt psychocrypt

Labels
backend cpu bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jagerman @psychocrypt