Multiple pools via CLI #2422
Open
Multiple pools via CLI #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychocrypt
reviewed
Jun 9, 2019
| @@ -524,32 +531,38 @@ void executor::ex_main() | |||
| if(!cfg.tls) | |||
| dev_tls = false; | |||
|
|
|||
| if(!xmrstak::params::inst().poolURL.empty() && xmrstak::params::inst().poolURL == cfg.sPoolAddr) | |||
| auto& pool_from_params = find_if(xmrstak::params::inst().pools.begin(), xmrstak::params::inst().pools.end(), [&cfg](const xmrstak::pool &pool_from_params) { return pool_from_params.poolURL == cfg.sPoolAddr; }); | |||
There was a problem hiding this comment.
This line produces an error in linux:
xmrstak/misc/executor.cpp:534:35: error: invalid initialization of non-const reference of type ‘__gnu_cxx::__normal_iterator<xmrstak::pool*, std::vector<xmrstak::pool> >&’ from an rvalue of type ‘__gnu_cxx::__normal_iterator<xmrstak::pool*, std::vector<xmrstak::pool> >’
auto& pool_from_params = find_if(xmrstak::params::inst().pools.begin(), xmrstak::params::inst().pools.end(), [&cfg](const xmrstak::pool &pool_from_params) { return pool_from_params.poolURL == cfg.sPoolAddr; });
~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
There was a problem hiding this comment.
When using "auto" as variable type, compiler doesn't automatically use "const" qualifier, so in this case it should be "const auto&" for the line to be valid. It is always best to explicitly add "const" qualifier if the following code is not supposed to modify the variable contents, this will allow compiler to optimize the code better.
|
I will move this PR release after the next, since I need first check the error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supply multiple pools via CLI options by using pool-related options multiple times.
Better CLI options functionality makes xmr-stak easier to integrate, because command line parameters are generally easier to manage programmatically.