Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in condensation of HF #12704

Open
johodges opened this issue Mar 28, 2024 · 5 comments
Open

Bug in condensation of HF #12704

johodges opened this issue Mar 28, 2024 · 5 comments
Assignees

Comments

@johodges
Copy link
Collaborator

Describe the bug
We were running a model to evaluate the capability of FDS to model the condensation of HF. From what I can tell in the user guide it should be possible since gas and liquid phase properties are included in prop.f90. However, when we run the attached model with the latest FDS we get a crash in radi.f90:495 because FDS is trying to grab refractive index data from a lagrangian particle but the class < 0 corresponds to species mixtures.

To Reproduce

Steps to reproduce the behavior:

  1. Run the attached input file.

test_1c.txt

@rmcdermo
Copy link
Contributor

Thanks, we'll take a look.

@rmcdermo
Copy link
Contributor

Looks to me like @drjfloyd has this coded up only for water and fuel species.

@johodges For the time being, if you do not need radiation, the case seems to run with &RADI RADIATION=F/

@johodges
Copy link
Collaborator Author

Thanks, we'll go with that for now. We are planning to compare with some data we have found in the literature assuming that the functionality works. I'll let you know how it turns out.

@drjfloyd
Copy link
Contributor

drjfloyd commented Oct 3, 2024

I think the solution to this one is we need to add inputs for the refractive index to spec so the spec liquid properties can have them.

drjfloyd added a commit that referenced this issue Oct 3, 2024
FDS Source: Add REAL_ and COMPLEX_REFRACTIVE_INDEX to SPEC Issue #12704.
@drjfloyd
Copy link
Contributor

drjfloyd commented Oct 3, 2024

This should work now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants