Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple chem treated as finite rate #12788

Open
rmcdermo opened this issue Apr 13, 2024 · 2 comments
Open

Simple chem treated as finite rate #12788

rmcdermo opened this issue Apr 13, 2024 · 2 comments
Assignees

Comments

@rmcdermo
Copy link
Contributor

@drjfloyd Looks like we need to clean up some logic in read after the chem commit. I picked one of the simple cases to run, fds/Verification/Fires/fire_const_gamma.fds and I get this:

ERROR(XXX): REAC 1. Tracked species AIR used in a finite rate reaction without N_S defined is not a primitive species. (CHID: fire_const_gamma)
drjfloyd added a commit that referenced this issue Apr 13, 2024
FDS Source: temp fix for Issue #12788 remove error check
@drjfloyd
Copy link
Contributor

I have for now just commented out the error check.

drjfloyd added a commit to drjfloyd/fds that referenced this issue Oct 3, 2024
drjfloyd added a commit that referenced this issue Oct 3, 2024
FDS Source: Add error codes and address Issue #12788
@drjfloyd
Copy link
Contributor

drjfloyd commented Oct 3, 2024

I think I have fixed this. We only need to go into that block of code for finite rate reactions. We also only only need to do the error check if the lumped species is a reactant (which includes products when REVERSE is TRUE).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants