-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smokeview: Right-click context menu does not open when eye point was moved into/through geometry #12848
Comments
sorry, I can't reproduce the error. |
try smokeview posted here. when you encounter the problem, click on the scene then press the 'P' key. see if the menus are then accessible with a right mouse click https://github.com/firemodels/test_bundles/releases/tag/SMOKEVIEW_TEST2 |
Same issue and no, pressing "P" and right clicking does not bring the menu back. Tested with SMV-6.9.2 on:
Is SMV maybe applying some condition regarding when the menu is available or not? Maybe it's not detecting or resetting them properly when inside or having moved outside of geometry. |
make sure you use the test smokeview at following url NOT smokeview 6.9.2 . I justed uploaded a new test smokview adding some debug print outputting menu state - whether menu is attached or detached to right mouse button. |
Your latest 6.9.2-52 testing release seems to fix the issue (tested in both scenarios), but I did not see any debug info in the console that I ran Smokeview from. |
you won't' see any debug output until you press the P key. each time you
press the P key a signal is sent to smokeview to attach the menu - even if
it is already attached. the P key also toggles on and off menu status
debug print (indicating whether menus are attached - ie whether the last
call was to attach a menu or to detach it)
…On Mon, Apr 29, 2024 at 11:17 AM FireResearch-BK ***@***.***> wrote:
I justed uploaded a new test smokview adding some debug print outputting
menu state - whether menu is attached or detached to right mouse button.
https://github.com/firemodels/test_bundles/releases/tag/SMOKEVIEW_TEST2
Your latest 6.9.2-52 testing release seems to fix the issue (tested in
both scenarios
<#12848 (comment)>),
but I did not see any debug info in the console that I ran Smokeview from.
—
Reply to this email directly, view it on GitHub
<#12848 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC6UCRREQOW6JQDRWMQJR4TY7ZP7PAVCNFSM6AAAAABGZHL3WKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBTGAYTKMZQHE>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
Glenn Forney
|
Ah, I missed that part. If I press "P" and move the camera around in the test case above, each and every interaction with the SMV window such as rotating the view via mouse triggers the menu status log message. In around 700 interactions, I never saw anything but "menu attached" and the menu worked each and every time I wanted to open it. Are there any changes the menu handling code in SMV 6.9.2-52 compared to SMV 6.9.2? |
No changes except adding debug print code. Is it working in this test
version?
…On Mon, Apr 29, 2024, 12:09 PM FireResearch-BK ***@***.***> wrote:
Ah, I missed that part. If I press "P" and move the camera around in the
test case above, each and every interaction with the SMV window such as
rotating the view via mouse triggers the menu status log message. In around
700 interactions, I never saw anything but "menu attached" and the menu
worked each and every time I wanted to open it.
Are there any changes the menu handling code in SMV 6.9.2-52 compared to
SMV 6.9.2?
—
Reply to this email directly, view it on GitHub
<#12848 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC6UCRWGLP3SUEMOFILHDJTY7ZWD5AVCNFSM6AAAAABGZHL3WKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBTGEZTGMBUHA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Yes, it is. Oddly enough... |
I'll close the case. Let me know if it happens again |
it was just luck that the smokeview you were using started working. I found a problem that was causing menus to not work right. I was incrementing an index variable twice instead of once . smokeview with fix is posted at link below. let me know if you continue to see a problem |
After a quick test on complex geometry with a current test bundle (commit: firemodels/test_bundles@9f7876d), I can confirm that the issue does not occur anymore. |
Smokeview release: SMV-6.9.1-0-gd0b04d0-release
Issue:
When moving the eye point into and at least after having moved it through a room made of obstructions, Smokeview's right click menu stops working, i.e. will not open.
Reproduction:
With more complex rooms, I've had this happen when inside of them as well.
Expected behavior:
The text was updated successfully, but these errors were encountered: