-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unnecessary call to WALL_MODEL? #13235
Comments
Yes, I suspect this is there to provide U_TAU and Y_PLUS. And I suspect it was put there because something else broke because it was not there, but I can't recall what. We would probably just have to remove it and see what firebot complains about. |
Looking at the log for velo.f90, it looks like this call was added on 4/02/2012 in dd91f6d add Van Driest damping to near wall turbulent viscosity. |
Could we have our cake and eat it too by adding
|
FDS Source: Issue #13235. Move call to WALL_MODEL
I moved the call to Marcos -- see me about doing the same for GEOM. |
Ok, I'll look into this. Thanks, |
OK, I think that this is just a printout thing. That is, we were making this call to |
My bad, looks like this works in wall.f90:
|
FDS Source: Issue #13235. Allow printout of Y+ and U_tau
Try it now. |
…op in wall.f90.
FDS Source : Issue #13235, move wall model call to CFACE loop in wall…
Completed. |
I need to clean up the use of
T_IGN
and in the process I ran into this call invelo.f90
around line 385Is this call necessary given that we also call the
WALL_MODEL
inVELOCITY_BC
. It seems that its only purpose is to provide values forB2%U_TAU
andB2%Y_PLUS
which raises two questions:WALL_MODEL
inVELOCITY_BC
?The text was updated successfully, but these errors were encountered: