Skip to content
This repository has been archived by the owner on Feb 15, 2021. It is now read-only.

Deploy to fwd.tools #136

Merged
merged 6 commits into from
May 25, 2020
Merged

Deploy to fwd.tools #136

merged 6 commits into from
May 25, 2020

Conversation

dbpolito
Copy link
Member

No description provided.

@dbpolito dbpolito requested a review from fabriciojs May 25, 2020 18:29

class Deploy extends Task
{
const URL = 'http://fwd.tools';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be https, and also possibly come from an ENV variable por easier changing for testing.

@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #136 into 1.0-rc will decrease coverage by 4.23%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             1.0-rc     #136      +/-   ##
============================================
- Coverage     86.54%   82.31%   -4.24%     
- Complexity      373      385      +12     
============================================
  Files            78       80       +2     
  Lines          1011     1063      +52     
============================================
  Hits            875      875              
- Misses          136      188      +52     
Impacted Files Coverage Δ Complexity Δ
app/Commands/Deploy.php 0.00% <0.00%> (ø) 1.00 <1.00> (?)
app/Environment.php 93.97% <ø> (ø) 28.00 <0.00> (ø)
app/Tasks/Deploy.php 0.00% <0.00%> (ø) 11.00 <11.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02018d9...131c4c1. Read the comment docs.

@dbpolito dbpolito merged commit adb43a7 into fireworkweb:1.0-rc May 25, 2020
@dbpolito dbpolito deleted the fwd_tools branch May 25, 2020 19:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants