This repository has been archived by the owner on Feb 15, 2021. It is now read-only.
Several Changes + Tests #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriciojs
suggested changes
Mar 25, 2019
app/Environment.php
Outdated
| } | ||
|
|
||
| protected static function loadEnv($envFile): void | ||
| public function loadEnv($envFile, $overload = false): void |
There was a problem hiding this comment.
instead of a bool flag that changes the method behaviour, let's have two different methods that perform each of the loads (safe / overload)
There was a problem hiding this comment.
this way the calling of the method is clearer to what it is suppose to do
app/Environment.php
Outdated
| { | ||
| return static::getContextPath() . '/docker-compose.yml'; | ||
| } | ||
|
|
||
| public static function getDefaultFwd() | ||
| public function getDefaultFwd() | ||
| { | ||
| return static::getDefaultPath() . '/.fwd'; |
There was a problem hiding this comment.
below we are using sprintf for concat strings... maybe worth expanding the pattern to the whole class at least
fabriciojs
approved these changes
Mar 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.