Fixed undefined behaviour in dip3-deterministicmn.py test

firoorg · Aug 20, 2024 · 988f1c6 · 988f1c6
1 parent 11e8a40
commit 988f1c6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/qa/rpc-tests/dip3-deterministicmns.py b/qa/rpc-tests/dip3-deterministicmns.py
@@ -61,6 +61,7 @@ def run_test(self):
         self.log.info("creating collateral for mn-before-dip3")
         before_dip3_mn = prepare_mn(self.nodes[0], 1, 'mn-before-dip3')
         create_mn_collateral(self.nodes[0], before_dip3_mn)
+        lock_mn_collateral(self.nodes[0], before_dip3_mn)
         mns.append(before_dip3_mn)
 
         # block 550 starts enforcing DIP3 MN payments
@@ -96,6 +97,7 @@ def run_test(self):
             else:
                 self.log.info("create_collateral %s" % mn.alias)
                 create_mn_collateral(self.nodes[0], mn)
+                lock_mn_collateral(self.nodes[0], mn)
                 self.log.info("register %s" % mn.alias)
                 register_mn(self.nodes[0], mn)
 
@@ -191,6 +193,7 @@ def run_test(self):
         # self.test_instantsend(10, 3, timeout=20)
 
     def spend_mn_collateral(self, mn, with_dummy_input_output=False):
+        unlock_mn_collateral(self.nodes[0], mn)
         return self.spend_input(mn.collateral_txid, mn.collateral_vout, 1000, with_dummy_input_output)
 
     def update_mn_payee(self, mn, payee):

diff --git a/qa/rpc-tests/test_framework/mn_utils.py b/qa/rpc-tests/test_framework/mn_utils.py
@@ -46,6 +46,12 @@ def create_mn_collateral(node, mn):
             break
     assert(mn.collateral_vout != -1)
 
+def lock_mn_collateral(node, mn):
+    node.lockunspent(False, [{'txid': mn.collateral_txid, 'vout': mn.collateral_vout}])
+
+def unlock_mn_collateral(node, mn):
+    node.lockunspent(True, [{'txid': mn.collateral_txid, 'vout': mn.collateral_vout}])
+
 # register a protx MN and also fund it (using collateral inside ProRegTx)
 def register_fund_mn(node, mn):
     node.sendtoaddress(mn.fundsAddr, 1000.001)