Libspats cleanup refacor #1517
Merged
Libspats cleanup refacor #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
levonpetrosyan93
added a commit
that referenced
this pull request
Feb 10, 2025
* copy from libspark * change name to spats * add generators * push testing * add constructor coin * fixed parameter * add parameter com3 * implement bpplus proof * implement bpplus proof * update gitignore * implement bpplus proof * update Coin inputs in spend tx * implement identify and test cases * fix prepare value proof and verify * add label transcript for balance * implement balance proof * fix return verify * fix return verify * remove unnecessary * add balance unit test * add label BaseAsset * implement base asset * add base asset unit test * check bad statement * add testcase base asset proof * add type equality prove * add test case * add mint unit test * improve solution * chage type in MintedCoinData struct * ay * fix conditions and fix verify com * modify * spend test * Update Makefile.test.include * Update Makefile.test.include * Update Makefile.test.include * add iota and a in SerializationOp * Spend transaction * add verify spend_transaction * update walltet backup dump * import multiexponent * edit the amount of the required memory * change a, iota types to Scalar * edit typo * update computation using multiexponent * edit the boolean logic * change a, iota types to Scalar * remove unnecessary variables * edit variable type * add throw exceptions * change variable type to Scalar * add test cases * change variable types to Scalar * add filenames for building * test for pushing * test for deleting * test for pushing * Spark address ownership proofs implemented. * Missing files added * Changes to compile with C++20 (#1505) * switch compilation to C++20 * fixed C++20 detection code * fixed compile errors with C++20 * further changes to support C++20 compilation * removed temporarily added compile-time assertion * added comments regarding dependency library upgrades for the future * Switched compilation to C++20 for BDB too * CI C++20 proper (#1514) * attempt to fix C++20 CI by upgrading Docker image to Ubuntu 24.04 * more targeted #inclusion of boost_function_epilogue.hpp * Trying to resolve Jenkins compile error by using #include "./boost_function_epilogue.hpp" * adding boost_function_epilogue.hpp to Makefile.am to fix the CI build error * Spats admin gui (#1497) * Initial mock-up of the 'My Own Spats' page on the GUI * fixed qt/myownspats build errors * restored accidentally removed code * My Own Spats GUI appearance fixes + added buttons * Addressed coderabbitai comments on 'My Own Spats GUI' changes * Libspats cleanup refacor (#1517) * Cleanup and refactor * More cleanup * Reverted some changes, bug fixes * More fixes --------- Co-authored-by: JusAeng <justo_play@hotmail.com> Co-authored-by: Naveeharn Tehmarn <naveeharn@hotmail.com> Co-authored-by: Nuttanan29445 <nuch29445@gmail.com> Co-authored-by: Manhermak Praditpong <69078506+DiFve@users.noreply.github.com> Co-authored-by: Jus <69185572+JusAeng@users.noreply.github.com> Co-authored-by: DiFve <jkblade6@gmail.com> Co-authored-by: naveeharn <naveeharn@email.com> Co-authored-by: Gevorg Voskanyan <gevorgvoskanyan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.