-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code links missing relative paths in template? #189
Comments
These are the placeholders we got so far: I guess $FILENAME should contain the whole path, not only the file name, I guess that is the problem. Do you want to take a stab and try to send a pull request to fix it? It's odd because I thought the filename would already contain the whole path. This is the REST API endpoint we are using: |
hmm, indeed filename does return the whole path; see this example:
https://api.github.com/repos/publiclab/plots2/commits/40f6b3f12c55b99b2346f2a4da36d2835bb88b9d
What could be happening here?
…On Mon, Feb 26, 2018 at 3:20 PM, Gregor Martynus ***@***.***> wrote:
These are the placeholders we got so far:
https://github.com/hoodiehq/first-timers-bot/blob/
8d327ba/lib/create-issue.js#L5-L9
I guess $FILENAME should contain the whole path, not only the file name, I
guess that is the problem.
Do you want to take a stab and try to send a pull request to fix it? It's
odd because I thought the filename would already contain the whole path.
This is the REST API endpoint we are using:
https://developer.github.com/v3/repos/commits/#get-a-single-commit
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#189 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJwg0pyQMw6dCjUEw2T2sYf4iUVwzks5tYxIJgaJpZM4STiSs>
.
|
This commit dates from Oct 11 2017... could this be related? |
I think i have this, working on regex now... :-) |
Yes - opening PR now:
|
see first-timers#189 -- if this passes, then first-timers#190 should fix it!
Test and fix in different commits in #192. |
Hi, we're VERY happy uses of this bot -- it's AMAZING!
I noticed in a recent PR that the link to code is not quite right.
publiclab/plots2#2398
See
app/models/node.rb
links to https://github.com/publiclab/plots2/blob/master/node.rb in the Step By Step item.It's supposed to link to: https://github.com/publiclab/plots2/blob/master/app/models/node.rb
Do we have this set up wrong?
[$FILENAME]($BRANCH_URL)
is in our config file: https://github.com/publiclab/plots2/blob/master/.github/first-timers-issue-template.mdWhat variables are allowed in there? And I can't seem to find the example file anymore, has this changed?
Thanks so much!!!
The text was updated successfully, but these errors were encountered: