Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] add docs for macos #544

Merged
merged 3 commits into from
Oct 6, 2024
Merged

[chore] add docs for macos #544

merged 3 commits into from
Oct 6, 2024

Conversation

Tps-F
Copy link
Contributor

@Tps-F Tps-F commented Sep 13, 2024

Is this PR adding new feature or fix a BUG?

Fix BUG.

Is this pull request related to any issue? If yes, please link the issue.

https://discord.com/channels/1214047546020728892/1214047661758484531/1284118763767070750
#461 (comment)

I just added the installation instructions on macOS to the documentation.

@Tps-F Tps-F marked this pull request as draft September 13, 2024 14:39
@leng-yue
Copy link
Member

Any update so we can merge this?

@Tps-F
Copy link
Contributor Author

Tps-F commented Oct 4, 2024

Sorryfor late, I have been busy studying for college exams lately and have not yet been able to look into the cause of the slowdown on the mps device.

I will add some warnings tomorrow and then I hope you will check this PR as is!

I will create another PR later on about faster inference speeds.

@Tps-F Tps-F marked this pull request as ready for review October 6, 2024 10:15
@Tps-F
Copy link
Contributor Author

Tps-F commented Oct 6, 2024

I'm really Sorry for the delay.
I have added about usage and current warnings.
For Chinese and Portuguese, I used a translator, so if there are any oddities, I would appreciate it if you could correct them!

@leng-yue
Copy link
Member

leng-yue commented Oct 6, 2024

LGTM, thanks for your contribution :)

@leng-yue leng-yue merged commit 82aa6e8 into fishaudio:main Oct 6, 2024
1 check passed
@Tps-F
Copy link
Contributor Author

Tps-F commented Oct 6, 2024

Of course, thank you!
I want to keep contributing to this project from now on as well

@brainstorm
Copy link

brainstorm commented Nov 6, 2024

If you want to perform inference on MPS, please add the --device mps flag.

Add the --device mps flag where exactly (which command)? Please provide an example.

EDIT:

Ok, I guess that flag goes to the command found in entry entrypoint.sh, so:

python tools/webui.py --device mps

Also (should I open a separate issue?): cachetools should be installed via pyproject.toml's runtime dependencies:

% python tools/webui.py --device mps
Traceback (most recent call last):
  File "/Users/rvalls/dev/personal/fish-speech/tools/webui.py", line 25, in <module>
    from tools.api import decode_vq_tokens, encode_reference
  File "/Users/rvalls/dev/personal/fish-speech/tools/api.py", line 42, in <module>
    from cachetools import LRUCache, cached
ModuleNotFoundError: No module named 'cachetools'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants