Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken remove_parameterization in firefly #620

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

med1844
Copy link
Contributor

@med1844 med1844 commented Oct 17, 2024

Is this PR adding new feature or fix a BUG?

This is a developer-side bug fix that addresses an issue with VQGAN parameterization removal. This bug does not affect end users under normal circumstances, as remove_parameterization is not used in any other part of the codebase.

The following code (forked from tools/vqgan/inference.py) triggers the error:

model: FireflyArchitecture = load_model(config_name, checkpoint_path, device=device)
model.remove_parametrizations()

Error message:

ValueError: Module FishTransConvNet(
  (conv): ParametrizedConvTranspose1d(
    512, 256, kernel_size=(16,), stride=(8,)
    (parametrizations): ModuleDict(
      (weight): ParametrizationList(
        (0): _WeightNorm()
      )
    )
  )
) does not have a parametrization on weight

Is this pull request related to any issue? If yes, please link the issue.

No

@leng-yue leng-yue merged commit 2cef13f into fishaudio:main Oct 18, 2024
1 check passed
@leng-yue
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants