fix(settings): networking tab input

[nelson137]

Fixes #933

Disabling only gamepad input seems to make the input behave as one would expect. Arrow keys, backspace, etc work like normal, and bound keys (e.g. A, D) only update the text and no longer move the caret.

Unfortunately I don't have a controller to test with, but I assume this will work with those kind of inputs too.

[MaxCWhitehead]

It's interesting to me that this fixes it, I wonder if disable_gamepad_input is not named very well?

This does seem to fix the issue with A/D, but I don't quite understand it. Anywho I'll test with gamepad at some point to make sure this doesn't impact anything outside network tab - am slightly concerned if leave the network menu gamepad will remain disabled but not sure.

Thanks!

[nelson137]

Yeah I was surprised it just worked. Re-reading through the 1 usage of disable_gamepad_input now it makes more sense:

• inputs are always parsed and the just_moved, move_direction, etc. are still set on the player controllers
• and when not disable_gamepad_input, a player controller with a move direction of left (.x < -0.1) would cause an egui::Key::ArrowLeft input event to be pushed to egui's events, for example

So the player controller is still registering A/D as left/right, but those aren't causing Arrow{Left,Right} events (which are read by the text area and would make the caret move).

am slightly concerned if leave the network menu gamepad will remain disabled but not sure

From my experimentation with egui, anything done to the context is scoped to that part of the UI, so leaving the networking tab would be in a different scope that doesn't have the EguiInputSettings set...? (Every now and then I jump into egui code but rarely understand what's going on.) And A/D still work after going into character selection.