Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(network-diagnostics): Install bones network debug window #919

Merged
merged 5 commits into from
Mar 9, 2024

Conversation

MaxCWhitehead
Copy link
Collaborator

Install the bones network debug egui plugin / add a button to open it from debug window.

Companion PR to fishfolk/bones#345

@zicklag
Copy link
Member

zicklag commented Mar 2, 2024

I merged the bones PR so you should be able to run cargo update to make CI pass for this now.

@MaxCWhitehead
Copy link
Collaborator Author

Merged main to resolve cargo.lock conflict

@zicklag zicklag enabled auto-merge March 9, 2024 18:17
@zicklag
Copy link
Member

zicklag commented Mar 9, 2024

I think there might be a security warning that is going to block merging. Hopefully we can just run cargo update to fix it if that's the case.

@MaxCWhitehead
Copy link
Collaborator Author

MaxCWhitehead commented Mar 9, 2024

I think there might be a security warning that is going to block merging. Hopefully we can just run cargo update to fix it if that's the case.

I just ran cargo update in the merge from main - so it seems these are still around. I can take a swing at resolving some of these cargo deny errors if you would like. And if stuck with problems upstream, can at least start tracking them.

@zicklag
Copy link
Member

zicklag commented Mar 9, 2024

Oh, I've already got the advisories set as non-required for merge, so it looks like all we need to do is add Unicode-3.0 to our allowed licenses list.

@MaxCWhitehead
Copy link
Collaborator Author

Oh, I've already got the advisories set as non-required for merge, so it looks like all we need to do is add Unicode-3.0 to our allowed licenses list.

PR opened: #923

@zicklag zicklag added this pull request to the merge queue Mar 9, 2024
Merged via the queue into fishfolk:main with commit 62e6694 Mar 9, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants