Fix/test cleanup #1578
Fix/test cleanup #1578
Conversation
This is consistent with the way that unit tests import utils.py and also fixes an import issue with our test environment.
We're getting a bunch of deprecation warnings when running the unit tests due to using statements like assertEquals instead of assertEqual. This change removes these warnings. Change completed via these Linux commands: $ cd test/unit $ sed -i 's/self.assertEquals/self.assertEqual/g' test_*.py $ sed -i 's/self.assertNotEquals/self.assertNotEqual/g' test_*.py
There was a problem hiding this comment.
I actually took care of assertEquals -> assertEqual here: #1490 - it just isn't in wilt-chamberlain, it's in our next version's dev branch, but I dig your style :)
I still approve this PR because of the import fix, I'll clean up the merge into louisa-may-alcott if there's any trouble there - sometimes git gets mad when you make the same fix twice
This is to remove deprecation warnings during testing. Linux commands (with globstar shell option enable): $ cd test $ sed -i 's/self.assertEquals/self.assertEqual/g' **/*.py $ sed -i 's/self.assertNotEquals/self.assertNotEqual/g' **/*.py
|
Sounds good! I also noticed that a couple integration tests needed to be updated as well. I just committed that change to the branch before I saw your approval on this change. I hope that doesn't cause additional trouble! |
|
No problem, just takes me a pull + push to the pr/ branch! Bigquery had an ephemeral failure with |
|
Thanks for your contribution @heisencoder! |
This branch contains some misc. test cleanup that I noticed while updating our internal build system with the latest dbt alpha release. It includes fixes to remove deprecation warnings during testing and also a minor update to have test_context.py do a local import of mock_adapter.py (in a manner consistent with how other tests import utils.py).