-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: allow dataclasses >= 0.6, < 0.9 #3151
chore: allow dataclasses >= 0.6, < 0.9 #3151
Conversation
This pull request isn't mergeable because it points to your private versions of hologram. I guess you just want to see if the CircleCI tests pass? |
@gshank yes that's what @jtcohen6 advised to do. So it will go like this I guess:
|
@gshank ah I see you merged the hologram PR. Let me know when there's a new version that I can replace the pointer to fork with |
There's a new version, 0.0.14 |
Damn that's blazing fast @gshank I'll update in a wee bit. |
@gshank alright change done. Btw, I had a question in the PR description around this checklist item:
Let me know what you think and I can change accordingly. Also, which release of dbt can we expect this change to be rolled into and when would that be (roughly)? |
core/setup.py
Outdated
@@ -69,8 +69,8 @@ def read(fname): | |||
'isodate>=0.6,<0.7', | |||
'json-rpc>=1.12,<2', | |||
'werkzeug>=0.15,<2.0', | |||
'dataclasses==0.6;python_version<"3.7"', | |||
'hologram==0.0.13', | |||
'dataclasses==0.7;python_version<"3.7"', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also actually I'm not sure if we should pin strictly to 0.7 here or let it be like the hologram depenency which is >=0.6,<0.9
I gravitate towards the latter otherwise we're not really solving the issue of having too strict dependencies, what do you think @gshank ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with having this match the hologram dependency exactly: 'dataclasses>=0.6,<0.9;python_version<"3.7"'
feels right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice quick work @bastienboutonnet! Thanks for the assist @gshank.
I definitely think this is worthy of a Changelog update + adding yourself to the list of Contributors :)
core/setup.py
Outdated
@@ -69,8 +69,8 @@ def read(fname): | |||
'isodate>=0.6,<0.7', | |||
'json-rpc>=1.12,<2', | |||
'werkzeug>=0.15,<2.0', | |||
'dataclasses==0.6;python_version<"3.7"', | |||
'hologram==0.0.13', | |||
'dataclasses==0.7;python_version<"3.7"', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with having this match the hologram dependency exactly: 'dataclasses>=0.6,<0.9;python_version<"3.7"'
feels right.
Thanks @jtcohen6 I added an entry in the changelog. Not sure if it will be going in |
9a4ed17
to
34174ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @bastienboutonnet!
resolves #3150
Description
As asked in #3150
dataclasses
could be allowed to vary more to make dbt cohabit with other projects which rely on version of dataclasses >0.6.@jtcohen6 thanks for the pointers in the ticket
A long time ago when I contributed to dbt I remember the CI doesn't run on external PRs is that still the case? If so, how should we go about checking that this change doesn't break as you instructed in #3150 ?
Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.