Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Envupdate crossupdate fix #1866

Merged

Conversation

RealHarshThakur
Copy link
Member

@RealHarshThakur RealHarshThakur commented Nov 26, 2020

Fixes: #1848

Functions with the environment weren't looked across namespaces.


This change is Reviewable

Signed-off-by: Harsh Thakur <harshthakur9030@gmail.com>
@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #1866 (146c30c) into master (ec22e22) will decrease coverage by 7.32%.
The diff coverage is 6.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1866      +/-   ##
==========================================
- Coverage   28.41%   21.08%   -7.33%     
==========================================
  Files          69       52      -17     
  Lines        5040     3723    -1317     
==========================================
- Hits         1432      785     -647     
+ Misses       3390     2867     -523     
+ Partials      218       71     -147     
Impacted Files Coverage Δ
pkg/crd/crdvalidations.go 100.00% <ø> (ø)
pkg/fission-cli/cmd/function/update.go 0.00% <ø> (ø)
pkg/router/analytics.go 0.00% <ø> (ø)
pkg/router/functionReferenceResolver.go 0.00% <0.00%> (ø)
pkg/router/httpTriggers.go 0.00% <0.00%> (ø)
pkg/router/metrics.go 88.88% <ø> (ø)
pkg/router/mutablemux.go 80.00% <ø> (ø)
pkg/router/requesthHeader.go 0.00% <ø> (ø)
pkg/router/router.go 0.00% <0.00%> (ø)
pkg/utils/rbacutils.go 0.00% <ø> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4a0aa3...22ba94e. Read the comment docs.

@vishal-biyani vishal-biyani added this to the 1.12.0 milestone Feb 4, 2021
@vishal-biyani vishal-biyani merged commit e2376c2 into fission:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fission environment image updates not getting reflected in NewDeploy function pods.
3 participants