Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add release workflow for keda connectors #61

Merged
merged 7 commits into from
May 11, 2021
Merged

add release workflow for keda connectors #61

merged 7 commits into from
May 11, 2021

Conversation

suramya-shah
Copy link
Contributor

@suramya-shah suramya-shah commented May 5, 2021

The release workflow will be triggered when:

  • there is a merge at the master branch and **/version file is changed.
    Following things are achieved in the workflow:
  • builds the docker image and pushes it to the respective docker hub repository of the connector
  • tags the image as latest, version no. mentioned in the file.
    Adding reference to 7.

@RealHarshThakur
Copy link
Member

RealHarshThakur commented May 6, 2021

@suramya-shah I think it would be nice if you add a new section around the version file in the https://github.com/fission/keda-connectors/blob/master/CONTRIBUTING.md file .

@RealHarshThakur
Copy link
Member

Also, we added a new connector for GCP recently. We should include that in this in PR too

@vishal-biyani
Copy link
Member

Hey @suramya-shah One last request. We do already have images with v0.5 as tag. So we should bump the one in this PR to v0.6 so that old images are preserved and new one are tagged. I am assuming once we merge - this will build and push all images?

@suramya-shah
Copy link
Contributor Author

yes @vishal-biyani , now it should.

@RealHarshThakur
Copy link
Member

I think the GCP one should be 0.1 @suramya-shah

@vishal-biyani vishal-biyani merged commit eb6d1ea into fission:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants