-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add ability to union multiple Google Ads connectors together #34
Comments
Hey @zhyatt, thanks for submitting this feature request! The Union Schema is a very popular feature and we are aware that customers are interested in having this feature included in a number of packages that currently don't have it. I'll note this as another request for adding the feature to the Google Ads package and will get back with when we can expect to have this implemented. |
Hi @zhyatt, to update you, I will working on this union update this quarter. Stay tuned! |
Hi @zhyatt, I have created a test branch with the ability to union multiple ad connectors together. If you are able to try it out, you can install it using the below code in your - git: https://github.com/fivetran/dbt_google_ads_source.git
revision: MagicBot/add-union-schema
warn-unpinned: false Also, below are the instructions from the README on how to set it up. Let us know if you have any questions about this as well. We look forward to any feedback you have!
|
@fivetran-catfritz Thanks for notifying me of this update, great to see it happening. I was able to test this branch using the setup instructions provided and got it working, so it looks like the change will work for us! 🎉 I will note that installing this via the Based on a separate issue with the same error, this appears to be a dependency resolution problem due to using the Thanks again for the update! |
Hi @zhyatt thanks for the update! I'm glad the source was working out for you. I didn't realize you were also using our - git: https://github.com/fivetran/dbt_google_ads.git
revision: MagicBot/add-union-schema
warn-unpinned: false As for the other dependency issues, we did cut a release earlier today that caused some issues for users, but we have since rolled it back, so wondering if that will also resolve things for you. |
Thanks @fivetran-catfritz , that branch for the |
Awesome! We should officially be releasing the new version with these changes in the next couple weeks. We'll keep you posted! |
This feature has been added to v0.10.0 and released today! Closing out this issue, but please continue to let us know any feedback! |
Is there an existing feature request for this?
Describe the Feature
I noticed that the Facebook Pages Source dbt package provides an option to union together multiple instances of Facebook Pages connectors for Fivetran: https://hub.getdbt.com/fivetran/facebook_pages_source/latest/. That option isn't available for the Google Ads Source package (https://hub.getdbt.com/fivetran/google_ads_source/latest/), but I am interested in having that included so I can utilize it.
This would likely use the existing
union_data
function in dbt_fivetran_utils package (https://github.com/fivetran/dbt_fivetran_utils/tree/v0.4.2/#union_data-source) similar to how it was done in Facebook Pages.Describe alternatives you've considered
We currently work around this limitation with two main changes:
ref()
function (a bit hacky), which preserves the ability to have fully integrated scheduling in Fivetran. Here is an example of how the overrides were done indbt_project.yml
:Are you interested in contributing this feature?
Anything else?
No response
The text was updated successfully, but these errors were encountered: