-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add final_url_suffix and include in campaign reports. #36
Comments
@dlubawy and/or @jocelyn-metricbox I wanted to clue you in here as I have been able to make the updates highlighted within the conversation form PR #33. Before moving forward with these changes and opening a new PR to incorporate the updates in the next release, I would like for you to confirm that these updates look appropriate with your data. To test the working branch, would you be able to update your packages:
# - package: fivetran/google_ads
# version: [">=0.9.0", "<0.10.0"]
- git: https://github.com/fivetran/dbt_google_adse.git
revision: customer/final-url-suffix-add
warn-unpinned: false Once you add this to your For a full list of all the changes in this WIP branch, you can view the comparisons below: |
We took a look on our end and realized that we may be missing the integration of
Then the To summarize:
Does this make sense? |
Hi @dlubawy thanks for the great response here and my apologies for my delay in getting back to you. So if I am understanding this correctly, there is a waterfall relationship with how these final_url_suffix may be assigned. Google Ads allows you to set the If this is true, I have a much better understanding of how these However, I do have on remaining question on this topic before going forward. Does the business care about these upstream Let me know if I am misunderstanding any points. If not, then I feel we can look to incorporate these full changes in our upcoming sprint. Thanks for collaborating with us! |
Sorry for taking so long to get back to you. I think you have the right general understanding in how it should work, but the workflow needs to be changed to after parsing the |
Is there an existing feature request for this?
Describe the Feature
Add final_url_suffix into stg_google_ads__campaign_history and stg_google_ads__ad_history and modified logic for extracting the UTMs.
Describe alternatives you've considered
Editing the package manually as opposed to being integrated in the official live version of the package.
Are you interested in contributing this feature?
Anything else?
Please see PR #34 and PR #42 for more details
The text was updated successfully, but these errors were encountered: