Feature/add typeid #109
Merged
Feature/add typeid #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
CHANGELOG.md
Outdated
Comment on lines
3
to
10
| - In the [May 2023 connector update](https://fivetran.com/docs/applications/hubspot/changelog#may2023) `type_id` was added to sources `DEAL_COMPANY` and `DEAL_CONTACT` as a part of the composite primary key for these tables. This column has been adding to the corresponding staging models. ([PR #100](https://github.com/fivetran/dbt_hubspot_source/pull/100)) | ||
| - Updated tests for these tables with `type_id` as part of the primary key. ([PR #100](https://github.com/fivetran/dbt_hubspot_source/pull/100)) | ||
| - Also resulting from the connector update, columns `updated_at` and `created_at` have been added to the following sources and their corresponding staging models: ([PR #100](https://github.com/fivetran/dbt_hubspot_source/pull/100)) | ||
| - `DEAL_PIPELINE` | ||
| - `DEAL_PIPELINE_STAGE` | ||
| - `TICKET_PIPELINE` | ||
| - `TICKET_PIPELINE_STAGE` | ||
| - Updated docs with these changes and a little housekeeping. ([PR #100](https://github.com/fivetran/dbt_hubspot_source/pull/100)) |
There was a problem hiding this comment.
the PR references should be for PR #109 right?
There was a problem hiding this comment.
Yes, thank you. Updated!
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature:
#106
This PR will result in the following new package version:
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
Because of the May 2023 connector update
type_idwas added toDEAL_COMPANYandDEAL_CONTACT. These tables are not pulled into the transform package.Also resulting from the connector update, columns
updated_atandcreated_athave been added to the following sources and their corresponding staging models:DEAL_PIPELINEDEAL_PIPELINE_STAGETICKET_PIPELINETICKET_PIPELINE_STAGEThese columns do get pulled into the transform package, for which I opened a PR on the transform.
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
Standard Updates
Please acknowledge that your PR contains the following standard updates:
DECISIONLOG updates have been updated (if applicable)dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
🐈