Update/crm api v3 - contact merge audit removed #98
Conversation
|
will regen docs before merging |
There was a problem hiding this comment.
@fivetran-jamie just a few minor requests and callouts. Let me know if you have any other questions!
CHANGELOG.md
Outdated
| [PR #98](https://github.com/fivetran/dbt_hubspot_source/pull/98) applies the following changes: | ||
| - Ensures that all timestamp fields are explicitly cast as timestamps (without timezones). | ||
| - Updates logic around the recently deprecated `CONTACT_MERGE_AUDIT` table. | ||
| - In [November 2022](https://fivetran.com/docs/applications/hubspot/changelog#november2022), the Fivetran Hubspot connector switched to v3 of the Hubspot CRM API, which deprecated the `CONTACT_MERGE_AUDIT` table and stored merged contacts in the `property_hs_calculated_merged_vids` column in the `CONTACT` table. **This has not been rolled out to BigQuery warehouses yet.** |
There was a problem hiding this comment.
Is there a way we can provide a little more direction on a timeline for BigQuery users? Or just provide some details to let BigQuery users to have an understanding of when this will be updated for them.
There was a problem hiding this comment.
bumped drew but he's ooo till monday
There was a problem hiding this comment.
@fivetran-jamie this is looking great and I feel it is very close to being able to merge through. I do just have one remaining comment regarding the hubspot_contact_merge_audit_enabled variable and how we use it for BigQuery users. I think we need to rethink how we use this variable. We can chat during standup.
Additionally, I came across a bug when doing more rigorous testing and ended up opening PR #100 to address the issue. We can batch this with these changes. It would be great if you could review.
There was a problem hiding this comment.
Thanks for working through the updates @fivetran-jamie! After final review, these look good to go!
Are you a current Fivetran customer?
internal
What change(s) does this PR introduce?
aligns with recent changes to the hubspot API
property_hs_calculated_merged_vidsfield to the contact model/macro and its seed datahubspot_contact_merge_audit_enabledto FALSE.Did you update the CHANGELOG?
Does this PR introduce a breaking change?
default behavior is different for most users (though they should end up with the same result...so maybe not?)
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
😩
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.