Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add event_extension var #31

Merged
merged 15 commits into from
Jul 25, 2024
Merged

Conversation

fivetran-reneeli
Copy link
Contributor

@fivetran-reneeli fivetran-reneeli commented Jul 17, 2024

PR Overview

This PR will address the following Issue/Feature:
internal ticket

In tandem with the downstream PR #44

This PR will result in the following new package version: v0.9.0

Non breaking as the default config for event_extension is still true so existing users won't see any changes.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Bug Fixes

  • Introduces variable iterable__using_event_extension to disable the stg_iterable__event_extension model. This allows the downstream models to run even if the source event_extension table does not exist. For more information on how to configure refer to the README.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

Variables tried:

    iterable_user_history_pass_through_columns:
      - name: phone_number_line_type
        alias: phone_digits
      - name: additional_properties
    iterable_event_extension_pass_through_columns:
      - name: browser_token
    iterable__using_event_extension: true
#    iterable__using_event_extension: false
    

If you had to summarize this PR in an emoji, which would it be?

💃

@fivetran-reneeli fivetran-reneeli self-assigned this Jul 18, 2024
@fivetran-reneeli
Copy link
Contributor Author

will regen docs upon approval

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@fivetran-avinash fivetran-avinash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-reneeli Looking good! A few minor comments to address before approval.

Also one major one: You'll need to regenerate docs.

fivetran-reneeli and others added 4 commits July 22, 2024 15:01
Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>
Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>
Copy link
Contributor

@fivetran-avinash fivetran-avinash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fivetran-reneeli ! Let me know when you've regenerated the docs and I can go ahead and approve this.

Copy link
Contributor

@fivetran-avinash fivetran-avinash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-reneeli Approved!

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-reneeli thanks for working on this PR. This mostly looks good there is just one final update that needs to be applied:

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-reneeli thanks for making these changes. This looks good to me!

@fivetran-reneeli fivetran-reneeli merged commit d0a989e into main Jul 25, 2024
7 checks passed
@fivetran-reneeli fivetran-reneeli deleted the add_event_extension_table_disable branch July 25, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants