-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add event_extension var #31
Conversation
will regen docs upon approval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-reneeli Looking good! A few minor comments to address before approval.
Also one major one: You'll need to regenerate docs.
Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>
Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fivetran-reneeli ! Let me know when you've regenerated the docs and I can go ahead and approve this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-reneeli Approved!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-reneeli thanks for working on this PR. This mostly looks good there is just one final update that needs to be applied:
- You need to add the config: enabled: block to the src.yml for the event_extension source table. This way, if the event_extension source is not present and the model is disabled then the source freshness will not be run for that source. If we do not include this logic the source freshness test will fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-reneeli thanks for making these changes. This looks good to me!
PR Overview
This PR will address the following Issue/Feature:
internal ticket
In tandem with the downstream PR #44
This PR will result in the following new package version: v0.9.0
Non breaking as the default config for event_extension is still true so existing users won't see any changes.
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Bug Fixes
iterable__using_event_extension
to disable thestg_iterable__event_extension
model. This allows the downstream models to run even if the sourceevent_extension
table does not exist. For more information on how to configure refer to the README.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Variables tried:
If you had to summarize this PR in an emoji, which would it be?
💃