Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/databricks get url parameter #56

Closed
wants to merge 10 commits into from

Conversation

fivetran-catfritz
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz commented Nov 20, 2023

PR Overview

This PR will address the following Issue/Feature:

This PR will result in the following new package version:

  • v0.8.1

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

  • Created macro extract_uri_parameter for use in the stg_linkedin_ads__creative_history. This was added to create special logic for Databricks instances not supported by dbt_utils.get_url_parameter().

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present)

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied. Check:
    • dbt_project.yml
    • integration_tests/dbt_project.yml
    • README
    • CHANGELOG
    • packages.yml
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

  • Was able to reproduce the error in Databricks SQL by running the compiled code generated by dbt_utils.get_url_parameter:

Screenshot 2023-11-20 at 2 18 40 PM

  • By using code for Databricks that does not reply on split(), the issue is resolved, and you can see that the parameters are extracted correctly:

Screenshot 2023-11-20 at 5 57 36 PM

@fivetran-catfritz fivetran-catfritz self-assigned this Nov 20, 2023
@fivetran-catfritz fivetran-catfritz linked an issue Nov 20, 2023 that may be closed by this pull request
4 tasks
@fivetran-joemarkiewicz
Copy link
Contributor

Closing this as PR #64 addressed this initial issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] dbt_utils.get_url_parameter does not work for databricks
2 participants