Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE - Add Passthrough Columns to Locations Model #9

Closed
1 of 3 tasks
oreoana opened this issue Oct 20, 2021 · 4 comments
Closed
1 of 3 tasks

FEATURE - Add Passthrough Columns to Locations Model #9

oreoana opened this issue Oct 20, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@oreoana
Copy link

oreoana commented Oct 20, 2021

Are you a Fivetran customer?
Yes -- Blue Bottle Coffee

Is your feature request related to a problem? Please describe.
I'd like to be able to add pass-through columns to some of the Netsuite staging models, specifically stg_netsuite__locations.

Describe the solution you'd like
Be able to specify pass-through columns for the locations staging model in the netsuite_source package using the existing approach here: https://github.com/fivetran/dbt_netsuite_source#configuration

Describe alternatives you've considered
Build our own Netsuite locations staging model.

Please indicate the level of urgency and business impact of this request
Medium -- would allow us to set up a better infrastructure for our locations data pipeline.

Are you interested in contributing to this package?

  • Yes, I can do this and open a PR for your review.
  • Possibly, but I'm not quite sure how to do this. I'd be happy to do a live coding session with someone to get this work implemented.
  • No, I'd prefer if someone else did this. I don't have the time and/or don't know how to incorporate the changes necessary.
@oreoana oreoana added the enhancement New feature or request label Oct 20, 2021
@fivetran-joemarkiewicz fivetran-joemarkiewicz changed the title FEATURE - [your feature request title here] FEATURE - Add Passthrough Columns to Locations Model Oct 25, 2021
@fivetran-joemarkiewicz
Copy link
Contributor

Hi @oreoana

Thanks so much for opening this feature request! I have added this feature request to our backlog and we will let you know back here once we are able to assign this request to a future sprint.

However, in the meantime as this is a relatively easy addition to the package (and I see you are open to contributing) then I would highly recommend opening a PR against the master branch for this addition. You can follow the same process of this variable as shown in stg_netsuite__accounts model and name the variable in line with the other ones. I am thinking locations_pass_through_columns. Let me know if you have any questions, otherwise we will let you know here once we are able to tackle this request in a future sprint.

Thank you!

@fivetran-joemarkiewicz
Copy link
Contributor

@oreoana I actually am working on a similar PR #10 where the pass through columns for customers is being added. I will build off this PR and add the locations variable as well.

@fivetran-joemarkiewicz
Copy link
Contributor

@oreoana I wanted to provide an FYI that the locations_pass_through_columns variable was included in the latest release of the dbt_netsuuite_source package. You can expect the package to be live on the dbt hub at the top of the hour.

Thanks again for opening this issue! 😄

@oreoana
Copy link
Author

oreoana commented Nov 2, 2021

@fivetran-joemarkiewicz great! Thanks so much for this!

jmongerlyra added a commit to jmongerlyra/dbt_netsuite_source that referenced this issue Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants