-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable vendor_categories and multibook accounting tables #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work and research here @fivetran-jamie -- I've approved the PR as it has no critical blockers for merge. But in addition to the in-line comments, I have a couple of questions for you:
- do you think it would be worth it to add these vars in our circleci tests (.circlci/config.yml)?
- Should the configs be added to the get column macros for
get_accounting_books_columms
,get_accountbooksubsidiaries_columns
andget_vendorcategory_columns
?
Other than that, I tested both variables using
dbt run --vars '{netsuite2__using_vendor_categories: false}'
and dbt run --vars '{netsuite2__multibook_accounting: false}'
and both seem to be running smoothly as well as dbt test
.
nah i don't think the macros need to be configured at all -- the macros are called within the models that themselves have configs (so if a model doesn't run, the macro won't be called) |
For timestamp fields not converted by the NetSuite UI, cast as date
Are you a current Fivetran customer?
Fivetran made PR
What change(s) does this PR introduce?
Adds variables to disable sources and models associated with vendor_categories and accounting_book_subsidiaries
Did you update the CHANGELOG?
Does this PR introduce a breaking change?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
🐀
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.