Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable vendor_categories and multibook accounting tables #21

Merged
merged 6 commits into from
Sep 21, 2022

Conversation

fivetran-jamie
Copy link
Contributor

Are you a current Fivetran customer?

Fivetran made PR

What change(s) does this PR introduce?

Adds variables to disable sources and models associated with vendor_categories and accounting_book_subsidiaries

Did you update the CHANGELOG?

  • Yes

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

  • CircleCi
  • Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

🐀

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

@fivetran-jamie fivetran-jamie changed the title disable vendor_categories and accounting_book_subsidiaries disable vendor_categories and multibook accounting tables Sep 19, 2022
@fivetran-sheringuyen fivetran-sheringuyen self-assigned this Sep 20, 2022
Copy link
Contributor

@fivetran-sheringuyen fivetran-sheringuyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work and research here @fivetran-jamie -- I've approved the PR as it has no critical blockers for merge. But in addition to the in-line comments, I have a couple of questions for you:

  • do you think it would be worth it to add these vars in our circleci tests (.circlci/config.yml)?
  • Should the configs be added to the get column macros for get_accounting_books_columms, get_accountbooksubsidiaries_columns and get_vendorcategory_columns?

Other than that, I tested both variables using
dbt run --vars '{netsuite2__using_vendor_categories: false}' and dbt run --vars '{netsuite2__multibook_accounting: false}' and both seem to be running smoothly as well as dbt test.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@fivetran-jamie
Copy link
Contributor Author

  • Should the configs be added to the get column macros for get_accounting_books_columms, get_accountbooksubsidiaries_columns and get_vendorcategory_columns?

nah i don't think the macros need to be configured at all -- the macros are called within the models that themselves have configs (so if a model doesn't run, the macro won't be called)

@fivetran-jamie fivetran-jamie merged commit 799a3d9 into main Sep 21, 2022
@fivetran-jamie fivetran-jamie deleted the feature/disable-vc-abs branch February 2, 2023 23:50
jmongerlyra added a commit to jmongerlyra/dbt_netsuite_source that referenced this pull request Aug 16, 2024
For timestamp fields not converted by the NetSuite UI, cast as date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants