Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Union schema compatibility #28

Merged
merged 19 commits into from
Oct 12, 2023

Conversation

fivetran-catfritz
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz commented Sep 1, 2023

Issue: #27

Confirm the following files were correctly updated automatically:

  • CHANGELOG
  • README
  • stg_facebook_ads.yml, src_facebook_ads.yml, facebook_ads.yml (depending if source or transform)
  • docs.md
  • joins
  • window functions (partition by)
  • 'source_relation' column added in staging and transform models
  • tests

Manual updates:

  • Add source_relation to downstream models if necessary
  • Finish any incomplete/incorrect joins/partitions
  • Update tests to include source_relation in unique-combination-of-cols if necessary
    • May need to remove some uniqueness tests in favor of the combo test

Validation:

  • dbt run locally passes
  • dbt test locally passes

@fivetran-catfritz fivetran-catfritz linked an issue Sep 1, 2023 that may be closed by this pull request
4 tasks
@fivetran-catfritz fivetran-catfritz self-assigned this Sep 1, 2023
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-catfritz these changes are looking great! However, I would like us to try and modify the package so we may avoid needing to update fivetran_utils. Would you be able to explore those updates and apply/document them if possible. Other than that, I just have a few additional notes.

CHANGELOG.md Outdated Show resolved Hide resolved
models/src_pinterest_ads.yml Outdated Show resolved Hide resolved
packages.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-catfritz this is looking great! I just have a clarifying question if the actual schema and database variables needed to be changed? I don't think they do, but curious if you found a reason why they would need to be updated.

I mainly ask because this is a pretty large breaking change. It is appropriate that this will already be included with other breaking changes, but if we could avoid this one then that would be ideal. This way it makes the upgrade that much smoother.

CHANGELOG.md Show resolved Hide resolved
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates! This looks good to go @fivetran-catfritz 🏅

@fivetran-catfritz
Copy link
Contributor Author

Merging for release on 12-Oct-2023.

@fivetran-catfritz fivetran-catfritz merged commit 1eccae2 into main Oct 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add union schema capability
2 participants