-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Union schema compatibility #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-catfritz these changes are looking great! However, I would like us to try and modify the package so we may avoid needing to update fivetran_utils. Would you be able to explore those updates and apply/document them if possible. Other than that, I just have a few additional notes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-catfritz this is looking great! I just have a clarifying question if the actual schema and database variables needed to be changed? I don't think they do, but curious if you found a reason why they would need to be updated.
I mainly ask because this is a pretty large breaking change. It is appropriate that this will already be included with other breaking changes, but if we could avoid this one then that would be ideal. This way it makes the upgrade that much smoother.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these updates! This looks good to go @fivetran-catfritz 🏅
Merging for release on 12-Oct-2023. |
Issue: #27
Confirm the following files were correctly updated automatically:
joinsManual updates:
source_relation
to downstream models if necessarysource_relation
in unique-combination-of-cols if necessaryValidation:
dbt run
locally passesdbt test
locally passes