Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: Issue #32
This PR will result in the following new package version:
v0.10.2
This will not be a breaking change since this will not impact the end results of the models. This will simply choose to partition by
source_relation
if that feature is being used or not.Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
In addition to relying on the standard buildkite integration tests, I was able to confirm the compilation state based off these changes for the following scenarios. Please note, this is only validating the ad_group_history model. However, since the code changes are consistent across the other models this should be appropriate coverage.
source_relation
since that is no longer a constant expression and should be included in the window function to differentiate sources.Additionally, I was able to test that these changes work as expected and do not cause any issues when using this version in downstream dependencies:
If you had to summarize this PR in an emoji, which would it be?
🥧