Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add created_at and updated at fields #58

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

fivetran-avinash
Copy link
Contributor

@fivetran-avinash fivetran-avinash commented Nov 18, 2024

PR Overview

This PR will address the following Issue/Feature:

This PR will result in the following new package version:

Added fields into various models, but nothing in particular will break for the customer I believe.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

  • We introduced these present fields that existed in these sources to their equivalent staging models.
    • created_at: bill, credit_memo, invoice
    • updated_at: bill, credit_memo, deposit, invoice, journal_entry, purchase, refund_receipt, sales_receipt, vendor_credit
  • These fields are then being brought in downstream in the dbt_quickbooks package in the quickbooks__general_ledger model via the double entry transaction intermediate models. You can learn more about these changes in the v0.17.0 release of the dbt_quickbooks package.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

If you had to summarize this PR in an emoji, which would it be?

💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant