Update README.md #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-jamie
requested changes
Oct 25, 2024
README.md
Outdated
| @@ -17,7 +17,7 @@ | |||
| This package models Salesforce Marketing Cloud data from [Fivetran's connector](https://fivetran.com/docs/connectors/applications/salesforce-marketing-cloud). It uses data in the format described by [this ERD](https://fivetran.com/docs/connectors/applications/salesforce-marketing-cloud#schemainformation). | |||
|
|
|||
| The main focus of the package is to transform the core object tables into analytics-ready models: | |||
| <!--section="salesforce_marketing_cloud_model"--> | |||
| <!--section="salesforce_marketing_cloud_transformation_model"--> | |||
There was a problem hiding this comment.
Actually, perhaps should this line be deleted? I see we have a duplicate on line 28 , which is the more appropriate position for the tag I think, so could you update the section tag there?
There was a problem hiding this comment.
Oh, definitely, I am also confused :D
Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>
fivetran-jamie
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide your name and company
Milan Jovic - Fivetran
Link the issue/feature request which this PR is meant to address
https://fivetran.height.app/T-819487
Detail what changes this PR introduces and how this addresses the issue/feature request linked above.
How did you validate the changes introduced within this PR?
Which warehouse did you use to develop these changes?
Did you update the CHANGELOG?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Typically there are additional maintenance changes required before this will be ready for an upcoming release. Are you comfortable with the Fivetran team making a few commits directly to your branch?
If you had to summarize this PR in an emoji, which would it be?
🎉
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.
PR Template
Community Pull Request Template (default)
Maintainer Pull Request Template (to be used by maintainers)