Customer/add sub item #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add subscription item ID
14 tasks
There was a problem hiding this comment.
Hey @fivetran-joemarkiewicz, good work here! The notes I have here are similar to the source pkg - please refer to the in-line comments. Additionally, I believe this change also warrants a docs regenerate.
Thanks @fivetran-sheringuyen! I just applied updates off your review. Let me know if you have any questions. Also, the docs should have been regenerated from the initial PR. Let me know if you have any questions. |
Merged
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a customer created PR with some minor changes to ensure BuildKite testing functionality is integrated before merging to
main.See PR #50 for details around the updates applied within this PR.