Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve whitespace in int_zendesk__field_history #106

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

bcolbert978
Copy link
Contributor

Please provide your name and company
Brad Colbert, Fivetran 👋

Link the issue/feature request which this PR is meant to address
#105

Detail what changes this PR introduces and how this addresses the issue/feature request linked above.
Removes the whitespace-handling from the jinja function at the beginning of the script. Doing so causes the compiled SQL to maintain whitespace which may be unnecessary/unaesthetic but which definitely runs as valid SQL, without risk of the non-jinja comment joining the the actual SQL code.

How did you validate the changes introduced within this PR?
dbt run works.

Which warehouse did you use to develop these changes?
BigQuery

Did you update the CHANGELOG?

  • Yes

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Provide an emoji that best describes your current mood

🔳

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

PR Template

@fivetran-joemarkiewicz
Copy link
Contributor

Thanks @bcolbert978! At first glance this PR looks good to me. However, there are a few minor updates I would like to apply before merging this in order to be consistent with our updates (ie. update the changelog, increase version, etc.). Are you comfortable if I edit your branch directly to make these changes for you? No changes will be applied to your .sql file changes.

@bcolbert978
Copy link
Contributor Author

Hey Joe - sorry for the delay - feel free to update away :-)

@fivetran-joemarkiewicz
Copy link
Contributor

Thanks @bcolbert978! I will update your PR to include some changes! Also, if you are not on a tight schedule I may plan to batch your updates with the upcoming release that will also include the fix for Issue #107. This may delay the release for another week or so.

Let me know if that timeline is appropriate. Otherwise if this is needed ASAP I can roll this out in a patch release early next week.

@bcolbert978
Copy link
Contributor Author

I think my delayed reaction speaks for itself 🙃 feel free to roll in to your other changes.

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

FYI @fivetran-jamie can we regen the docs. Since we made the code change even though it is super small we should still update them to reflect the current codebase.

@fivetran-jamie fivetran-jamie merged commit 86e87d0 into main Aug 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants