Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/passthrough-addition #70

Merged
merged 5 commits into from
Apr 19, 2022

Conversation

fivetran-joemarkiewicz
Copy link
Contributor

Are you a current Fivetran customer?

Fivetran created PR

What change(s) does this PR introduce?

The zendesk__ticket_enriched and zendesk__ticket_metrics models now allow passthrough columns to be included through the use of the zendesk__ticket_passthrough_columns variable!

As these models already perform a select * on the ticket staging table, there was no need to make any code changes. This PR simply updates our documentation so users may know that they can leverage this new feature.

Did you update the CHANGELOG?

  • Yes

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)

This will not impact existing users. Simply custom passthrough fields from the source package will be added to the final models.

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Is this PR in response to a previously created Bug or Feature Request

  • Yes, Issue/Feature 26
  • No

How did you test the PR changes?

  • CircleCi
  • Local (please provide additional testing details below)

I was able to test this locally and see my own custom passthrough fields be present in the final models.

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

👯

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

packages.yml Outdated Show resolved Hide resolved
@fivetran-joemarkiewicz fivetran-joemarkiewicz marked this pull request as ready for review April 8, 2022 20:57
Copy link
Contributor

@fivetran-sheringuyen fivetran-sheringuyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @fivetran-joemarkiewicz! Just reviewed this PR and had a couple of questions. Let me know if you wanna talk about them!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
packages.yml Outdated Show resolved Hide resolved
packages.yml Outdated Show resolved Hide resolved
@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit d71581c into main Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants