Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert dataset length when using epochs #104

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

liPatrick
Copy link
Contributor

@liPatrick liPatrick commented Sep 4, 2024

Right now, max steps and epochs will crash with non generic datasets because their size has been set to 0 by default. As a workaround, the default size is set to 1, and an assert is added to check that real sizes are used when training with epoch.

Copy link
Contributor

@farzadab farzadab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liPatrick liPatrick merged commit 74e3998 into main Sep 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants