Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed lifetime unsoundness in arr macro. #99

Merged
merged 1 commit into from
Apr 10, 2020

Conversation

rodrimati1992
Copy link
Contributor

Fixed the lifetime unsoundness demonstrated in the arr! unsoundness issue

Added doctests (that don't appear in the public documentation) for cases that are expected to compile,and not compile.

The doctests could probably be replaced with something less hacky(like trybuild),but I'm not going to do that.

Added doctests (that don't appear in the public documentation) for cases that
are expected to compile,and not compile.
@novacrazy novacrazy merged commit 8ef64f9 into fizyk20:master Apr 10, 2020
@greyblake
Copy link

greyblake commented Mar 1, 2021

@fizyk20 @rodrimati1992 Would you consider it possible to backport the fix to 0.9 - 0.13 versions?

This will be very appreciated, because a big chunk of the ecosystem in direct or indirect way still relies on the old versions.
For example as-slice.

Thanks in advance.

@fizyk20
Copy link
Owner

fizyk20 commented Mar 2, 2021

I had the idea to do so yesterday evening and I'm working on it now :) I think that will be the fastest course of action here.

@greyblake
Copy link

@fizyk20 Thank you! Very appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants