Add get_create2_address()

[fjarri]

Supersedes #79

@artemki2077, compared to your original proposal I changed salt to be an integer argument - do you think it is sensible? The examples I found online seem to be all using uint256 as its type, but if in your usage you would have to call .to_bytes() every time, we may as well have it as bytes.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines	Coverage Δ
pons/__init__.py	100.00% <100.00%> (ø)
pons/_utils.py	100.00% <100.00%> (ø)

[artemki2077]

Supersedes #79

@artemki2077, compared to your original proposal I changed salt to be an integer argument - do you think it is sensible? The examples I found online seem to be all using uint256 as its type, but if in your usage you would have to call .to_bytes() every time, we may as well have it as bytes.

well, actually I would use bytes. Since I was initially experimenting with create 2 and there was a problem that for some reason the address was calculated incorrectly. As I suspect, this was due to the fact that in solidity uint256 takes 32 bytes, and in python int is translated without a fixed byte length value, which resulted in a different hash, so I used the written function, as well as the salt parameter in the function in the contract translated into bytes, since both there and there the bytes are the same as in python, and there were no problems. Mb I'm wrong

[artemki2077]

Supersedes #79
@artemki2077, compared to your original proposal I changed salt to be an integer argument - do you think it is sensible? The examples I found online seem to be all using uint256 as its type, but if in your usage you would have to call .to_bytes() every time, we may as well have it as bytes.

well, actually I would use bytes. Since I was initially experimenting with create 2 and there was a problem that for some reason the address was calculated incorrectly. As I suspect, this was due to the fact that in solidity uint256 takes 32 bytes, and in python int is translated without a fixed byte length value, which resulted in a different hash, so I used the written function, as well as the salt parameter in the function in the contract translated into bytes, since both there and there the bytes are the same as in python, and there were no problems. Mb I'm wrong

I'm sorry, I just noticed that the function is converting int to 32 bytes, so there are no problems. Cool

[fjarri]

I actually thought about it and returned the original bytes salt. Thought about making it strongly typed (like Address), but perhaps that's too much. Also I need to export TypedData from ethereum-rpc for that.

Added the get_create_address() as well.

[fjarri]

Do you want me to make a release, or did you want to add something else?

[artemki2077]

Do you want me to make a release, or did you want to add something else?

no, I wanted to add get_create_address, but as I looked, you have already implemented it

[fjarri]

Published v0.8.1 with this PR.