Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change version of RxSwift dependency in podspec #58

Closed
maxxx777 opened this issue Nov 7, 2018 · 2 comments
Closed

Change version of RxSwift dependency in podspec #58

maxxx777 opened this issue Nov 7, 2018 · 2 comments

Comments

@maxxx777
Copy link
Contributor

maxxx777 commented Nov 7, 2018

Hello,
We are migrating our project from Swift 4.1 to Swift 4.2.
The project and all its dependencies (except ReCaptcha) are using RxSwift 4.4.0. The problem is ReCaptcha 1.4 can not use version 4.4.0 of RxSwift because of rx.dependency 'RxSwift', '~> 4.3.1'
May it be replaced with e.g. rx.dependency 'RxSwift', '~> 4.3'? (ReCaptcha has no conflicts with RxSwift 4.4.0)

Please let me know if I could make PR to update podspec file.

@fjcaetano
Copy link
Owner

Hi @maxxx777, thanks for the heads up. That seems like a simple enough fix. Do you want to try and tackle that with a PR?

@maxxx777
Copy link
Contributor Author

maxxx777 commented Nov 8, 2018

@fjcaetano thanks for the reply, just did the PR.
Please let me know if I should update changelog file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants