Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Rx dependencies version from '~> 4.3.1' to '~> 4.3' #59

Merged
merged 2 commits into from
Nov 12, 2018
Merged

Change Rx dependencies version from '~> 4.3.1' to '~> 4.3' #59

merged 2 commits into from
Nov 12, 2018

Conversation

maxxx777
Copy link
Contributor

@maxxx777 maxxx777 commented Nov 8, 2018

Fix #58

@maxxx777 maxxx777 changed the title - Change Rx dependencies version from '~> 4.3.1' to '~> 4.3' in podsp… Change Rx dependencies version from '~> 4.3.1' to '~> 4.3' Nov 8, 2018
@maxxx777
Copy link
Contributor Author

maxxx777 commented Nov 9, 2018

@fjcaetano, regarding ci failure:

  • looks like pod repo update should be called on the travis to update RxSwift version.
  • test__Validate__Show_ReCaptcha is randomly failed on my machine, even before PR's changes.

@fjcaetano
Copy link
Owner

Hey @maxxx777, don't worry about Travis, we'll fix it later. Meanwhile, have you checked if Carthage is working correctly? I'm asking this because you didn't change Cartfile and I'm checking if it really isn't needed.

@maxxx777
Copy link
Contributor Author

@fjcaetano thanks for the note, completely forgot to check Carthage.
Carthage documentation about versioning confuses me a bit. But it looks like carthage update updates RxSwift to 4.4.0 even if Cartfile contains github "ReactiveX/RxSwift" ~> 4.3.1.
However, I did the updates in Cartfile to keep the same version of RxSwift dependency in both CocoaPods and Carthage.

@fjcaetano fjcaetano merged commit 484ed94 into fjcaetano:master Nov 12, 2018
@fjcaetano
Copy link
Owner

Release as version 1.4.1 🚀

Congrats @maxxx777 🎉

@maxxx777
Copy link
Contributor Author

@fjcaetano thank you!

Przemyslaw-Wosko pushed a commit to Przemyslaw-Wosko/ReCaptcha that referenced this pull request Apr 3, 2019
Merge branch 'master' of https://github.com/fjcaetano/ReCaptcha into …
364db9c 
…feature/improve-skipping-reCaptcha-for-ui-tests

* 'master' of https://github.com/fjcaetano/ReCaptcha:
  Add warning to uncheck verify origin settings in recaptcha (fjcaetano#68)
  Version Bump (1.4.2)
  Fix webview's resource loading detection
  Version Bump (1.4.1)
  Fix Fastlane test devices
  Updating documentation
  Change Rx dependencies version from '~> 4.3.1' to '~> 4.3' (fjcaetano#59)

# Conflicts:
#	ReCaptcha/Classes/ReCaptcha.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxxx777 @fjcaetano