Feature: Enable grecaptcha.render optional callback. #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
=========================================
- Coverage 96.39% 96.29% -0.1%
=========================================
Files 8 8
Lines 305 324 +19
=========================================
+ Hits 294 312 +18
- Misses 11 12 +1
Continue to review full report at Codecov.
|
fjcaetano
reviewed
Oct 22, 2019
ReCaptcha/Assets/recaptcha.html
Outdated
| // 'expired-callback': () => { | ||
| // post({ error: 28 }); | ||
| // clearObservers(); | ||
| // }, |
There was a problem hiding this comment.
Why is this commented out? It looks like the code will never catch "expired response" errors
There was a problem hiding this comment.
Thanks for your review! I did debug with commented out this, and I forgot to fix it. I didn't mean to comment out, so I will fix it.
|
Good stuff. I only have one question I commented above. Once that has been cleared, it's good to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to introduce following optional callbacks of
grecaptcha.render.expired-callbackerror-callbackcf. https://developers.google.com/recaptcha/docs/invisible
Currently, when the connectivity is lost after starting recaptcha sequence, there is no way to know the hanging.
error-callbackis called when a connectivity issue happens, and the result should be error.