Remove LibXSPEC_jll dependency #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decouple the LibXSPEC_jll from SpectralFitting and make it available as an additional package kept in this source tree. This package is called `XSPECModels`, and loading both SpectralFitting and XSPECModels will give exactly the same functionality as before. SpectralFitting can now be installed without the (currently only) Linux/Macos precompiled binaries. Updated the model paths to use `~/.julia/spectral_fitting_data` instead of the LibXSPEC_jll artifact directory, since this might be in an unknown location. The model data can now also be used between version changes without problem and more easily inspected / modified.
fjebaker
force-pushed
the
no-xspec
branch
4 times, most recently
from
efff511
to
37b1d47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting the efforts to decouple SpectralFitting from (troublesome) dependencies.
LibXSPEC_jll has only been compiled for Linux / Macos and select architectures. This means Windows users cannot install SpectralFitting. With this PR, the XSPEC model library is no longer a requirement for SpectralFitting and can instead be made available by explicitly installing and
usingXSPECModels from the AstroRegistry.