Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid add quote for "on" #526

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Conversation

maxisam
Copy link
Contributor

@maxisam maxisam commented Nov 16, 2022

fix #525

warning: this will cause some incompatible issue with Yaml 1.1 and below.

Basically it won't put quote on the following values

'y', 'Y', 'yes', 'Yes', 'YES', 'on', 'On', 'ON', 'n', 'N', 'no', 'No', 'NO', 'off', 'Off', 'OFF'

@fjogeleit fjogeleit merged commit ffe9752 into fjogeleit:main Nov 17, 2022
@fjogeleit
Copy link
Owner

@maxisam sorry I missed that, you have to run npm run all to build the changes you did. I will do this real quick.

@maxisam
Copy link
Contributor Author

maxisam commented Nov 17, 2022

it's alright. I usually put that step in my action repo like this
https://github.com/maxisam/path-labeler/blob/f4359e497184e04dd0cf12bb55eb7655fa20eed0/.github/workflows/CI.yml#L36

so I don't have to build it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

creating unwanted quote
2 participants