メソッドをリファクタリング

fjordllc · Jul 19, 2023 · 63175da · 63175da
1 parent 4adcfa8
commit 63175da
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/app/helpers/reports_helper.rb b/app/helpers/reports_helper.rb
@@ -11,12 +11,7 @@ def practice_options(categories)
 
   def practice_options_within_course
     user_course_categories = current_user.course.categories.includes(:practices)
-    user_practices = user_course_categories.flat_map do |category|
-      category.practices.map do |practice|
-        [practice.title, practice.id]
-      end
-    end
-    user_practices.uniq
+    user_course_categories.flat_map(&:practices).map { |practice| [practice.title, practice.id] }.uniq
   end
 
   def convert_to_hour_minute(time)

diff --git a/app/views/api/practices/index.json.jbuilder b/app/views/api/practices/index.json.jbuilder
@@ -1,10 +1,6 @@
 # frozen_string_literal: true
 
-user_practices = @categories.flat_map do |category|
-  category.practices
-end
-
-unique_practices = user_practices.uniq
+unique_practices = @categories.flat_map(&:practices).uniq
 
 json.array! unique_practices do |practice|
   json.(practice, :id, :title)