プラクティス一覧画面にアクセス時のN+1を解消 #3526
Merged
プラクティス一覧画面にアクセス時のN+1を解消 #3526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
カテゴリーごとにpracticesテーブルへクエリを発行していたのを一度のクエリにするため
rubocopの指摘事項
shibaaaa
commented
Nov 7, 2021
komagata
requested changes
Nov 11, 2021
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
プラクティス一覧画面に遷移時、practicesテーブルにカテゴリーの数分クエリが発行されていたので、一回のクエリで済むように修正しました。
practicesテーブルからstatusがcompleteのものをカウントし、category_idでグルーピングするように変更しています。