Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

提出物一覧のローディングをプレースホルダに変更 #3545

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

IkumaTadokoro
Copy link
Contributor

目的

UIの変更

loading-products-with-placeholder.mov

@IkumaTadokoro IkumaTadokoro self-assigned this Nov 9, 2021
@IkumaTadokoro
Copy link
Contributor Author

@Ichiyo14
お手数ですが、こちらレビューお願いいたします〜🙇‍♂️

@Ichiyo14
Copy link
Contributor

Ichiyo14 commented Nov 9, 2021

@IkumaTadokoro
確認しました! OKです✨

@IkumaTadokoro
Copy link
Contributor Author

@Ichiyo14
レビューいただきありがとうございました!!😊

@komagata
お手数ですが、こちらレビューお願いいたします〜🙇‍♂️

Copy link
Member

@komagata komagata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認しました、OKですー🙆‍♂️

@komagata komagata merged commit 63c6231 into main Nov 11, 2021
@komagata komagata deleted the feature/loading-products-with-placeholder branch November 11, 2021 07:27
@github-actions github-actions bot mentioned this pull request Nov 11, 2021
22 tasks
@IkumaTadokoro
Copy link
Contributor Author

@komagata
こちらメンター向けの機能のため、お手数ですが、本番環境での動作確認をお願いいたします🙇‍♂️

@komagata
Copy link
Member

@IkumaTadokoro 本番環境で動作することを確認しました。

@IkumaTadokoro
Copy link
Contributor Author

@komagata
ご確認いただきありがとうございました!🙇‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants