Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mentor_last_comment_at を mentor_last_commented_at に変更 #3549

Merged
merged 4 commits into from
Nov 15, 2021
Merged

mentor_last_comment_at を mentor_last_commented_at に変更 #3549

merged 4 commits into from
Nov 15, 2021

Conversation

IkumaTadokoro
Copy link
Contributor

@IkumaTadokoro IkumaTadokoro commented Nov 10, 2021 •
edited
Loading

目的

@IkumaTadokoro IkumaTadokoro self-assigned this Nov 10, 2021
@IkumaTadokoro IkumaTadokoro marked this pull request as ready for review November 10, 2021 07:49
@IkumaTadokoro
Copy link
Contributor Author

@mami-inuzuka
お手数ですが、こちらレビューお願いいたします〜🙇‍♂️

@mami-inuzuka
Copy link
Contributor

@IkumaTadokoro こちらレビュー遅くなりすみません🙇🏻‍♂️
良いと思います！！👍

@IkumaTadokoro
Copy link
Contributor Author

@mami-inuzuka
お忙しい中、レビューいただきありがとうございました😄🙏

@IkumaTadokoro
Copy link
Contributor Author

@komagata
お手数ですが、こちらレビューお願いいたします〜🙇‍♂️

komagata
komagata approved these changes Nov 15, 2021
View reviewed changes
Copy link
Member

@komagata komagata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認しました、OKですー🙆‍♂️

@komagata komagata merged commit 02e94d0 into main Nov 15, 2021
@komagata komagata deleted the feature/rename-last-comment-at-column-to-products branch November 15, 2021 18:32
@github-actions github-actions bot mentioned this pull request Nov 15, 2021
Merged
22 tasks
@IkumaTadokoro
Copy link
Contributor Author

@komagata
こちら提出物機能に関する内部修正のため、お手数ですがご確認お願いいたします🙇‍♂️
（振る舞い的には何も変わっていないので、提出者最終コメント日時とメンター最終コメント日時がこれまでどおり表示されていればOKだと思います）

@komagata
Copy link
Member

@IkumaTadokoro 本番環境で動作することを確認しました。

@IkumaTadokoro
Copy link
Contributor Author

@komagata
ご確認いただきありがとうございました！🙇‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komagata komagata komagata approved these changes

@mami-inuzuka mami-inuzuka Awaiting requested review from mami-inuzuka

Assignees

@IkumaTadokoro IkumaTadokoro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IkumaTadokoro @mami-inuzuka @komagata